Rename to test_mysql_no_override_global_sql_mode #7408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,11 +44,12 @@ def test_mysql_default_in_strict_mode | |||
| assert_equal [["STRICT_ALL_TABLES"]], result.rows | |||
| end | |||
|
|
|||
| def test_mysql_strict_mode_disabled | |||
| def test_mysql_no_override_global_sql_mode | |||
There was a problem hiding this comment.
Perhaps the test names could still have the strict_mode_disabled in them? Seems like it's what's being under test, not? How about:
test_mysql_strict_mode_disabled_dont_override_global_sql_mode
Or something like that?
There was a problem hiding this comment.
Thanks for the comment.
I was thinking what is the proper test name if MySQL default sql_mode would be changed to STRICT_ALL_TABLES. but it may be too much worrying about future.
I like your idea. test_mysql_strict_mode_disabled_dont_override_global_sql_mode shows its purpose correctly. I'll update my commit.
Reason since MySQL 5.6.6-m9 the `sql_mode` default value is `NO_ENGINE_SUBSTITUTION`. This default parameter change is out of control from Rails. This test verifies Rails not overriding the default `@@GLOBAL.sql_mode` value by checking if `@@GLOBAL.sql_mode` is the same as `@@SESSION.sql_mode`.
carlosantoniodasilva
added a commit
that referenced
this pull request
Aug 21, 2012
Change mysql tests for strict mode disabled to work with new sql_mode default in MySQL 5.6.6-m9. Since this MySQL version, the sql_mode default value is `NO_ENGINE_SUBSTITUTION`.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses two failures tested with MySQL 5.6.6 m9 (milestone 9).
It might have caused sql_mode default value as of MySQL 5.6.6 m9 is
NO_ENGINE_SUBSTITUTION, which was empty at older versions.This default parameter change is out of control from Rails, then these test verify Rails not overriding the default
@@GLOBAL.sql_modevalue by checking if@@GLOBAL.sql_modeis the same as@@SESSION.sql_mode.